[SPARK-56796][UI] Fix sticky tooltips for Stage page additional metrics#55771
Closed
XdithyX wants to merge 1 commit into
Closed
[SPARK-56796][UI] Fix sticky tooltips for Stage page additional metrics#55771XdithyX wants to merge 1 commit into
XdithyX wants to merge 1 commit into
Conversation
…r selecting Stage page checkboxes
Contributor
Author
|
Hi @sarutak Can you please have a look? |
sarutak
approved these changes
May 11, 2026
Contributor
Author
|
Thank you @sarutak for the review. Please let me know if anything else is needed. Otherwise, can we check this in? |
Contributor
Author
|
Hi @sarutak , gentle follow-up on this PR. Since it has already been approved, could we proceed with checking it in when convenient? Please let me know if anything else is needed from my side. Thanks! |
sarutak
pushed a commit
that referenced
this pull request
May 18, 2026
### What changes were proposed in this pull request? This PR updates the Stage page additional metrics tooltips to use `data-bs-trigger="hover"` ([SPARK-56796](https://issues.apache.org/jira/browse/SPARK-56796)). The change is limited to the additional metrics checkbox options under `Show Additional Metrics`, such as `Scheduler Delay`, `Task Deserialization Time`, `Getting Result Time`, and `Peak Execution Memory`. ### Why are the changes needed? Currently, after selecting one of the Stage page additional metrics checkboxes, the tooltip can remain visible even after the mouse leaves the option. This happens because Bootstrap tooltips use the default `hover focus` trigger. When a checkbox inside the tooltip target is clicked, focus can keep the tooltip active after mouseleave. For these checkbox options, the tooltip should only be shown while hovering. ### Does this PR introduce _any_ user-facing change? Yes. In the Stage page, tooltips for `Show Additional Metrics` checkbox options now disappear when the mouse leaves the option after selecting it. ### How was this patch tested? Manually tested in the Spark UI Stage page: 1. Opened a stage detail page. 2. Expanded `Show Additional Metrics`. 3. Hovered over an additional metric option to show the tooltip. 4. Selected the checkbox. 5. Moved the mouse away from the option. 6. Verified that the tooltip no longer remains visible after mouseleave. ### Was this patch authored or co-authored using generative AI tooling? Yes. Generated-by: OpenAI GPT-5.5 Codex ### Before the fix https://github.com/user-attachments/assets/c2ece423-5150-4478-b4e5-0931de396085 ### After the fix https://github.com/user-attachments/assets/9dde5476-412b-461b-a35b-bc40cea943a3 Closes #55771 from XdithyX/SPARK-56796. Authored-by: Adithya Ajith <4adhi007@gmail.com> Signed-off-by: Kousuke Saruta <sarutak@apache.org> (cherry picked from commit e20f55f) Signed-off-by: Kousuke Saruta <sarutak@apache.org>
Member
|
Merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates the Stage page additional metrics tooltips to use
data-bs-trigger="hover"(SPARK-56796).The change is limited to the additional metrics checkbox options under
Show Additional Metrics, such asScheduler Delay,Task Deserialization Time,Getting Result Time, andPeak Execution Memory.Why are the changes needed?
Currently, after selecting one of the Stage page additional metrics checkboxes, the tooltip can remain visible even after the mouse leaves the option.
This happens because Bootstrap tooltips use the default
hover focustrigger. When a checkbox inside the tooltip target is clicked, focus can keep the tooltip active after mouseleave.For these checkbox options, the tooltip should only be shown while hovering.
Does this PR introduce any user-facing change?
Yes.
In the Stage page, tooltips for
Show Additional Metricscheckbox options now disappear when the mouse leaves the option after selecting it.How was this patch tested?
Manually tested in the Spark UI Stage page:
Show Additional Metrics.Was this patch authored or co-authored using generative AI tooling?
Yes. Generated-by: OpenAI GPT-5.5 Codex
Before the fix
before.mov
After the fix
after.fix.mov